Conversation
…aultPii When a user is explicitly set on the scope, user.id, user.name, and user.email are now always attached to log and metric attributes, matching the existing behavior for error events (SentryClient.applyScope). Fixes #5078 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
romtsn
changed the title
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a416a65 | 333.78 ms | 410.37 ms | 76.59 ms |
| d15471f | 342.08 ms | 415.44 ms | 73.35 ms |
| e59e22a | 329.74 ms | 383.31 ms | 53.57 ms |
| d15471f | 315.20 ms | 370.22 ms | 55.02 ms |
| d364ace | 382.77 ms | 443.21 ms | 60.44 ms |
| b3d8889 | 371.33 ms | 426.24 ms | 54.92 ms |
| a416a65 | 316.52 ms | 359.67 ms | 43.15 ms |
| b03edbb | 352.20 ms | 423.69 ms | 71.49 ms |
| d15471f | 304.55 ms | 408.43 ms | 103.87 ms |
| 319f256 | 315.96 ms | 372.96 ms | 57.00 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a416a65 | 1.58 MiB | 2.12 MiB | 555.26 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| e59e22a | 1.58 MiB | 2.20 MiB | 635.34 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| d364ace | 1.58 MiB | 2.11 MiB | 539.75 KiB |
| b3d8889 | 1.58 MiB | 2.10 MiB | 535.07 KiB |
| a416a65 | 1.58 MiB | 2.12 MiB | 555.26 KiB |
| b03edbb | 1.58 MiB | 2.13 MiB | 557.32 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| 319f256 | 1.58 MiB | 2.19 MiB | 619.79 KiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
user.id,user.name, anduser.emailare now always attached to log and metric attributes, regardless of thesendDefaultPiiflagSentryClient.applyScope), which copies scope user without checkingsendDefaultPiiFixes #5078
Test plan
sendDefaultPiiisfalsesendDefaultPii = true🤖 Generated with Claude Code